AudioKit/AudioKit#2955#32
Conversation
emurray2
left a comment
emurray2
left a comment
There was a problem hiding this comment.
There should be a check on sequence if the length isn't long enough to accommodate, but surely this should be based on the maximum position + duration of any note added, rather than the sum of the durations of notes added irrelevant of their position.
Suggested changes in AudioKit/AudioKit#2955 by @pnome completed and ready for review
|
I didn't see me as a reviewer. I clicked on "Learn about draft PRs" and clicked the "Ask Admin For Access" button, but there wasn't any feedback to let me know that anything has happened. |
@pnome It didn't let me add either. You can review manually and leave a 👍 if everything looks good. |
|
Weird. It looks good to me. If you're able to merge and update the SPM I'll put it in the project and check it fixes the issue. Is there something I'd need to do it I wanted to contribute changes? |
Sounds like a good plan. It seems I don't have merge access, but for now you can download my fork if you want and then import it locally into Xcode. For contributing changes, you can make a fork on your GitHub of the repo you want to change. Then you make your changes to that fork. And when you're ready, you can make a new pull request with the matching repo in the repository you want to merge to. |
|
@aure @wtholliday Could we get this merged in? |
|
I'd love to get this merged in too! |
|
Right now, it is showing that the tests failed on last attempt. You can either make a trivial change and push it to trigger running the tests or check the tests on your machine, and push any chanages that are necessary. |
5 participants
Improve sequencer length handling to account for the issue described above