Prefix Generate* LDH ops with ldh-#18
Open
namedgraph wants to merge 3 commits into
Open
Conversation
`GeneratePortal`, `GenerateClassContainers`, and `GenerateOntologyViews` were the only ops under `linkeddatahub/` not registered with the `ldh-` prefix used by their siblings. Add `name()` overrides, update the example and README to match, and document a few previously unlisted ops while at it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Naming change to ldh-Generate* is breaking for any external workflow JSON referencing the bare names, so a minor bump is more appropriate than 1.3.1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
name()overrides toGeneratePortal,GenerateClassContainers, andGenerateOntologyViewsso they register asldh-GeneratePortal,ldh-GenerateClassContainers, andldh-GenerateOntologyViews— matching the convention used by every other op underlinkeddatahub/.examples/generate-portal.jsonto use the new name.Generate*ops plus a number of previously undocumented ones (Schema category,SPARQLString,STRUUID,Filter,Bindings,Current,Execute,Merge,ldh-AddFile).This is a breaking change for any external workflow JSON that references the bare
Generate*names, but those were the only LDH ops missing the prefix and no other examples/tests use them.Test plan
uv run pytest tests/— 106 passed, 44 skipped (same as before)name()returns prefixed strings via direct importexamples/generate-portal.jsonagainst a running LDH instance