Added watching kill signal and shutdown gracefully#23
Open
Ataba29 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds graceful shutdown handling so it responds correctly to Docker's stop signal, not just manual terminal input. main.cpp now registers a SIGTERM/SIGINT handler that sets a shared atomic flag instead of relying solely on a blocking read of stdin. Reading stdin was moved to its own thread so it no longer blocks the main thread from noticing a signal-triggered shutdown. The main thread now polls the shutdown flag at short intervals, converging both the typed "stop" command and OS signals (docker stop, Ctrl+C) on the same server.stop() shutdown path. The stdin thread is detached rather than joined at shutdown, since it may still be blocked waiting for input that will never arrive when a signal rather than a keystroke triggered shutdown.
Related to #17