Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR begins the C++23 refactor of ByteForge, starting with the networking and startup layer. main.cpp's server-accept thread now uses
std::jthreadinstead of std::thread, removing the need for a manual.join()call since it joins automatically on destruction.Server::start()now returnsstd::expected<void, std::string>instead of throwingstd::runtime_erroron bind/listen failure, giving main.cpp explicit control over the failure message and exit path rather than relying on an unhandled exception. Server's connections and busySockets members were converted fromstd::unordered_map/std::unordered_settostd::flat_map/std::flat_set, trading hash-bucket lookups for cache-friendlier contiguous storage, which suits their typically small size. A[[assume(bytesReceived > 0)]]hint was also added in messageHandler immediately after the two early-return branches that already rule out zero and negative values, letting the compiler skip re-deriving that invariant.Related to #19