fix: skip cron knowledge base injection

[EterUltimate]

Summary

• Skip non-agentic automatic knowledge-base injection for scheduled cron events.
• Add a regression test proving cron-triggered requests do not call retrieve_knowledge_base() or append KB results as user content.

Evidence

• Issue [Bug]新版将知识库注入改成了user消息导致定时任务触发时知识库注入相关内容被当做了刚刚的实时对话信息 #9018 reports scheduled tasks treating knowledge-base injections as recent user dialogue.
• PR perf(knowledge-base): inject knowledge base results as temporary user content to improve cache rate #8904 changed KB results to temporary user content, which is appropriate for user messages but misleading for synthetic cron prompts.
• astrbot/core/cron/manager.py builds cron requests with a fixed scheduled-task prompt, so automatic KB lookup uses the scheduler prompt rather than a real user utterance.

Verification

• uv run pytest tests/unit/test_astr_main_agent.py -k "apply_kb" -v: 8 passed.
• uv run ruff check astrbot/core/astr_main_agent.py tests/unit/test_astr_main_agent.py: passed.
• uv run ruff format --check astrbot/core/astr_main_agent.py tests/unit/test_astr_main_agent.py: passed.
• uv run astrbot --help: passed.
• bunx pnpm@10.28.2 install --frozen-lockfile && bunx pnpm@10.28.2 run build in dashboard/: passed.
• uv run pytest -q: 1648 passed, 28 failed locally on Windows in unrelated path/CRLF/file-uri/local-shell/config-directory tests.
• tests/test_code_quality_typing.py: absent on current master.

Notes

• Full ruff over the zipball copy scanned .venv because this was not a normal git checkout; source-file checks passed for the changed files.

Summary by Sourcery

Prevent knowledge-base injection from running for cron-triggered events and add coverage to ensure scheduled tasks do not treat KB results as user content.

Bug Fixes:

• Skip non-agentic knowledge-base lookup when handling cron platform events to avoid injecting KB results into synthetic scheduled-task prompts.

Tests:

• Add an async unit test verifying that _apply_kb does not call retrieve_knowledge_base or append extra user content for cron events.

[gemini-code-assist]

Code Review

This pull request introduces a check in _apply_kb to skip applying the knowledge base when the event platform is 'cron' and agentic mode is disabled. Additionally, a unit test has been added to verify this behavior. There are no review comments, and I have no further feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}