Make audit reconciliation writes portable across relational providers - #578
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The changed persistence and test paths are consistent with the existing model, transaction, and concurrency behavior.
Review effort: Lite
Findings: None
What changed in this PR
This PR makes audit reconciliation writes provider-portable while preserving concurrency checks, parameterization, and transaction behavior.
Changes:
- Replaces SQL Server-specific updates with
ExecuteUpdateAsync. - Generates parameterized inserts from EF Core metadata and provider quoting.
- Updates tests to recognize provider-specific identifier quoting.
| File | Description |
|---|---|
ApplicationAuditReconciler.cs |
Implements portable reconciliation updates and inserts. |
ApplicationAuditReconciliationTests.cs |
Makes write interception provider-agnostic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExecuteUpdateAsyncoperations.Validation
dotnet format ./NetCoreApplicationTemplate.slnx.dotnet restore ./NetCoreApplicationTemplate.slnxdotnet build ./NetCoreApplicationTemplate.slnx -c Release --no-restoredotnet test ./NetCoreApplicationTemplate.slnx -c Release --no-restore --no-build