Remove duplicate non-default scaffold assertions - #550
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the duplicated
none + sqlserverscaffold validation path from thetemplate-smoke-testjob.The
template-option-matrixjob already provides authoritative coverage for template option combinations througheng/Assert-TemplateOptionScaffold.ps1, including authentication settings, database provider selection, connection-string selection, SQL Server migration omission, migration-test absence, and migration-namespace-reference checks.Changes
ContosoNoAuthSqlServerscaffold step fromtemplate-smoke-test.template-option-matrixas the single source of truth for template option semantics.Rationale
Maintaining two separate implementations of the same option-specific assertions creates unnecessary CI duplication and increases the risk that the inline smoke-test checks drift from the shared assertion script.
This change clarifies CI responsibilities:
template-smoke-testvalidates package installation, default scaffold behavior, cross-platform build/test behavior, and Linux Docker/Compose execution.template-option-matrixvalidates authentication and database option combinations and their generated scaffold semantics.Validation
Assert-TemplateOptionScaffold.ps1retains SQL Server migration omission, migration-test absence, and migration-namespace-reference validation.none + sqlservercombination remains covered bytemplate-option-matrix.git apply --check.Closes #531.