Harden X publishing retries and sample concurrency - #353
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The OAuth self-test does not validate the generated signature, leaving signing regressions undetected.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Hardens X publishing retries and improves concurrency handling and documentation in the bounded-use sample.
Changes:
- Avoids unsafe POST retries while retaining bounded 429 retries.
- Adds UTF-8 OAuth signing and injectable timestamps.
- Synchronizes sample use-count reads and expands .NET artifact ignores.
| File | Summary |
|---|---|
tools/publish-x.cs |
Retry, OAuth, and self-test updates. Moderate finding: the self-test should assert the OAuth signature using deterministic inputs. |
samples/replay-protection-and-bounded-use/Sample/ReplayProtection.cs |
Thread-safe use-count observation and lifecycle documentation. |
.gitignore |
Additional IDE, test, coverage, and package artifact ignores. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Validation