COD-166 feat(attachments): surface Codex generated-artifact files as attachment cards#150
Merged
Ark0N merged 3 commits intoJul 12, 2026
Conversation
…rk0N#150) - Pass the attachment request `source` through the server deps lambda and make it a required param on SessionListenerDeps.registerAttachment + the wiring event type (the 2-arg lambda silently dropped `source`, force-confining every codex-generated artifact — the feature never worked outside the workspace); new test/session-listener-wiring.test.ts asserts the pass-through - Gate the Codex `Saved to: file://` scanner on mode === 'codex' via a codexArtifacts option threaded from the session call site; magic links stay mode-agnostic; tests assert claude/shell sessions never emit codex-generated requests - Decide the generated-artifact trust policy on the realpath-RESOLVED path (unresolvable → force-confined) and anchor the ~/.codex marker dirs to os.homedir() prefixes with startsWith instead of substring matching; symlink escape + unanchored-marker regression tests added - Run the Codex scanner on stripAnsi'd data so trailing SGR sequences don't ride into the captured URL; styled 'Saved to:' test added - Extend generateFirstPageThumbnail with jpg/jpeg/gif/webp passthrough and per-extension content types (mirrors the png passthrough) so the PR's new image formats render real thumbnails instead of 204 letter-tiles Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
|
Merged — thank you @aakhter! Codex artifact cards round out the attachment pipeline nicely. Review caught one silent killer — the server-side deps lambda dropped the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Saved to: file://...terminal output alongside existingcodeman://attach?...magic links, registering matching images/documents as attachment cards in real timeparseTerminalAttachmentRequests()inattachment-magic.ts— wraps the existing magic-link parser and adds a newparseCodexGeneratedArtifactRequests()scanner; oldparseAttachmentMagicLinks()is preserved as a thin alias returning paths onlysrc/generated-artifact-attachments.ts(net-new):registerGeneratedArtifactAttachment()routes Codex-sourced files through a relaxed path policy — workspace-confined by default, but bypassed for known Codex generated-image directories (~/.codex/generated_images/,~/.codex-personal/generated_images/, and thegenerated_artifacts/variants)SUPPORTED_ATTACHMENT_EXTENSIONSto include jpg/jpeg/gif/webp (Codex primarily generates PNGs and JPEGs)source: 'external' | 'codex-generated'through theattachmentRequestedevent →session-listener-wiring→registerAttachmentso the server can apply per-source trust policiesFiles changed
src/attachment-magic.tsparseTerminalAttachmentRequests,TerminalAttachmentRequest,parseCodexGeneratedArtifactRequests; refactors internalssrc/attachment-registry.tssrc/generated-artifact-attachments.tssrc/session.tsparseTerminalAttachmentRequests; emitssourceinattachmentRequestedeventsrc/web/server.tsregisterAttachmentacceptssourceparam; routes toregisterGeneratedArtifactAttachmentforcodex-generatedsrc/web/session-listener-wiring.tssourcetoattachmentRequestedandregisterAttachmentinterfacestest/attachment-magic.test.tsparseTerminalAttachmentRequeststest/generated-artifact-attachments.test.tsisAllowedGeneratedArtifactPathtable testsVerification
Downstream source: COD-152.