Refactor metadata_manager to move to versions provider based model#244
Conversation
metadata_manager to move to versions provider based model
7ab3df1 to
23eb457
Compare
peterbarker
left a comment
There was a problem hiding this comment.
Introduces a race condition where the SHA a user is dealing with can disappear while they're playing in the interface. Should be explicitly commented on somewhere. Even better if we can find a neat solution :-)
LGTM
23eb457 to
54a1884
Compare
|
Thanks for the review @peterbarker. I have addressed your comments.
The race was always there. Even when we used github tags to fetch releases. It is very hard to know if there is anyone on the client side who has fetched a SHA but it moved before the hit build. I will think about reducing the possibility of that happening. |
This PR refactors the versions manager to move to a versions provider based model.
We introduce three providers:-
I have tested this locally and it works good.
I will update #242 to use the same manifest json client we introduced in this PR to help listing the standard builds for a vehicle-version-release combination.