Closed
Conversation
Ensure version coherence prefers stable releases over matching pre-release tags, and make fetchAll toolkit metadata resolution use the same providerId fallback path as single-toolkit fetches. Made-with: Cursor
Reduce comparator complexity while preserving semver precedence behavior for stable and pre-release versions. Made-with: Cursor
Extract optional prerelease part comparison so the semver helper stays readable and below complexity warning thresholds. Made-with: Cursor
Fix redundant metadata lookups in fetchToolkitData and add regression tests for semver prerelease ordering plus metadata lookup behavior across single and bulk toolkit paths. Made-with: Cursor
Address review findings from six parallel reviewers:
- Use compareVersions for filter equality so semver-equal tools (e.g. @1.0.0 vs @1.0.0+build.1) no longer get silently dropped.
- Replace localeCompare("en") with ASCII byte ordering per SemVer 2.0.0 §11.4.2 so mixed-case prerelease tags rank correctly.
- Replace ambiguous best === "" sentinel with a null sentinel in getHighestVersion.
- Drop the allowToolkitIdLookup flag and lift the toolkit-id retry into the fetchAllToolkitsData call site; shared helper now only owns the *Api provider-id fallback.
- Inline single-use compareOptionalPrereleasePart and simplify comparePrereleaseIdentifier with typeof narrowing.
- Add regression tests: direct-map-hit no-relookup, patch-only version diff, ASCII prerelease ordering, string-vs-string prerelease, all-unversioned tools, semver-equal tools with differing build metadata.
Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Base automatically changed from
fix/version-coherence-prerelease-metadata-fallback
to
main
April 17, 2026 23:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated after a Porter deploy succeeded.
Note
Low Risk
Low risk because changes are confined to generated documentation/metadata JSON (tool listings, counts, timestamps) with no runtime code changes; main impact is potential drift if removed tools were expected to be documented.
Overview
Updates the generated toolkit docs data under
toolkit-docs-generator/data/toolkits.GitHub toolkit: removes the two notifications-related tools (
GetNotificationSummary,ListNotifications) and updates the toolkittoolCountaccordingly.Jira toolkit: drops two priority-scheme association tools and updates
toolCount.Linear toolkit: bumps docs metadata from
3.3.2to3.3.3and clarifiesUpdateIssue.assigneedocs to describe how to clear an assignee.Also refreshes
generatedAttimestamps and removes the embeddedsummaryfields from the GitHub and Jira JSON outputs.Reviewed by Cursor Bugbot for commit abd5c64. Bugbot is set up for automated code reviews on this repo. Configure here.