Skip to content

Refactor/improve parallel writing throughput#92

Merged
noamteyssier merged 8 commits into
mainfrom
refactor/improve-parallel-writing-throughput
Jun 26, 2026
Merged

Refactor/improve parallel writing throughput#92
noamteyssier merged 8 commits into
mainfrom
refactor/improve-parallel-writing-throughput

Conversation

@noamteyssier

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a more granular ingestion mechanism for parallel writing in the CBQ format. By splitting the ingestion process into ingest_completed (which drains already-compressed blocks off-lock) and ingest_incompleted (which flushes the residual incomplete block at thread completion), worker threads can continue accumulating records across batches without premature compression. Corresponding lifecycle hooks (on_thread_complete) have been added to the parallel reader and processor traits, along with comprehensive unit tests. The review feedback suggests two excellent performance optimizations: adding early-return checks in both ingest_completed (when there are no headers) and ingest_incompleted (when there are no records) to avoid redundant operations.

Comment thread src/cbq/write.rs
Comment thread src/cbq/write.rs
@noamteyssier noamteyssier merged commit 1826203 into main Jun 26, 2026
28 checks passed
@noamteyssier noamteyssier deleted the refactor/improve-parallel-writing-throughput branch June 26, 2026 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant