Repository navigation
find-appimage: a release's channel comes from its tag and AppImage names only; log the release choice - #9636
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
…hannel A latest-beta.json update feed (TennoScope uploads one to the latest stable release) made that release look like the beta channel, so the previous release was picked instead (#6700). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
probonopd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the wrong release in #6700 (TennoScope: v0.11.0 was tested although v0.12.0 and v0.13.0 exist) and makes such cases visible in the log.
Cause.
find-appimage.shleaves out releases of other channels (esr, nightly, beta, ...) unless the entry asks for one with#Channel. It decided a release's channel by looking at the names of all its assets. TennoScope uploads alatest-beta.jsonupdate feed to its latest stable release, so v0.13.0 (and before it v0.12.0) looked like the "beta channel" and was skipped; v0.11.0, which no longer carries that file, was picked.Fix. Only the tag and the names of the
.AppImagefiles tell the channel; other files of a release do not.Log. The newest 8 releases are listed in the order of the API, with draft / pre-release / release, the date, the number of AppImages and a
*at the chosen one, so the next case like this can be read from the log:Checked.
bash -n,shellcheck; replay on a release list with alatest-beta.json; the Firefox-style channel cases ("",ESR,Nightly,beta) still pick their own AppImage; and a throwaway Test run on the real TennoScope repository (closed again) now picks v0.13.0 where #6700's run picked v0.11.0.🤖 Generated with Claude Code
https://claude.ai/code/session_01DZvaN9tm5taf5avUvVtmyq
Generated by Claude Code