Skip to content

error-app-exits hint: the test runs without network on purpose, and so must the application #10020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
probonopd merged 2 commits into from
Oct 11, 2026
Merged

error-app-exits hint: the test runs without network on purpose, and so must the application #10020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4c8511
error-app-exits hint: the test runs without network on purpose, and s…
probonopd Oct 11, 2026
cb746a9
README: the no-network rule in one sentence
probonopd Oct 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ Then send a Pull Request to this repository. GitHub Actions will instantly perfo
### After you submit

* **Comments that run something:** `/retest` tests again; `/appstream` explains how to show your own screenshot (via the AppStream metainfo file). A comment that says a fix or a new release is out ("fixed in 1.2.3", "new release", "updated") re-tests a failed pull request automatically; "will be fixed in the next release" does not.
* **No network:** the test runs the application without network access, on purpose, and that is a requirement: an AppImage must start without network, or at least show a message; one that exits because it cannot reach a server fails with `error-app-exits`.
* **Labels:** `error-*` names why the test failed (the comment has the hint); `screenshot-ok` means it passed and the screenshot looked fine; `manual-check-needed` means a maintainer must look (e.g. the download location moved to another owner).
* **Merging:** pull requests will take some time to be reviewed by a maintainer.
* **Changed your mind?** Comment "please remove my app" (or "opt out") on the pull request: it gets the `opt-out` label and a maintainer closes it. The application is not proposed again.
Expand Down
2 changes: 1 addition & 1 deletion code/diagnose.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ HINTS=(

"^ERROR: The application exited within [0-9]+ seconds"
"error-app-exits"
"The application quit or crashed right after starting. The error below usually shows why."
"The application quit or crashed right after starting; the error below usually shows why. Note that the test runs the application without network access, on purpose, and that this is a requirement for the catalog: an AppImage must start without network (users are offline too). If the application needs a server, a login or an update check to start, please make it show its window (or at least a message) first and connect afterwards, and handle a failed connection instead of exiting."

"^ERROR: Could not find a single window on screen"
"error-no-window"
Expand Down