Fix bare ALD references being left as literal text#8
Closed
PiotrCzapla wants to merge 1 commit into
Closed
Conversation
{:note: #id .class} definitions were recognized, but a block or span
IAL consisting solely of the reference name ({:note} or {: note}) was
rejected by the looks_like_attrs gate, which only accepted bodies
containing '#', '.', or '='. Pass the ALD definitions map into the
gate so a token naming a defined attribute list also qualifies.
Undefined names still stay literal.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
Thanks for the report and fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Named attribute-list references used alone in an IAL will resolve after this pr.
This wasn't working previously:
{:note: #id .class} Some text {:note}but this was fine
{:note: #id .class} Some text {:note .some-class}Fix:
looks_like_attrsinsrc/attrs.rsgates whether a trailing{...}is treated as an attribute list, it recognizes it only if it containing#,., or=, so pure note{:note}was ignored.