Skip to content

Fix login when xdg config home directory does not exist#75

Merged
jph00 merged 1 commit intoAnswerDotAI:mainfrom
pporcher:make-xdg-config-home
Jan 6, 2026
Merged

Fix login when xdg config home directory does not exist#75
jph00 merged 1 commit intoAnswerDotAI:mainfrom
pporcher:make-xdg-config-home

Conversation

@pporcher
Copy link
Copy Markdown
Contributor

@pporcher pporcher commented Jan 6, 2026

This fixes an issue where login function was not able to write plash_config.json file if the xdg_config_home directory does not already exist.

Here is a dialog that reproduce the issue in a fresh solveit instance where xdg_config_home directory, aka /app/data/.config is not created yet.

The fix uses fastcore's Path extension write_json that does create parent directories if they do not exist.

@gitnotebooks
Copy link
Copy Markdown

gitnotebooks bot commented Jan 6, 2026

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/plash_cli/pull/75

@RensDimmendaal RensDimmendaal requested a review from jph00 January 6, 2026 14:02
@RensDimmendaal
Copy link
Copy Markdown
Contributor

Thanks! lgtm, nice use of fastcore's Path.write_json. Tagged @jph00 for review.

@jph00 jph00 added the bug Something isn't working label Jan 6, 2026
@jph00 jph00 merged commit 21797c1 into AnswerDotAI:main Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants