[PR] Prevent path traversal in static file routes (#912) - #919
Open
lackas wants to merge 1 commit into
Open
Conversation
3 tasks
lackas
force-pushed
the
fix-static-path-traversal
branch
from
August 27, 2026 06:29
e2a3703 to
409f355
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #912.
Proposed Changes
static_routeandstatic_route_extsinterpolate the{fname:path}URL segment straight intoFileResponse(f'{static_path}/{fname}…'). Thepathconverter matches.., so/%2e%2e/secret.mdresolves outsidestatic_pathand serves any file the worker process can read.New helper
_static_fpathresolves the request againststatic_pathand raisesHTTPException(404)if it escapes; both handlers route through it. The containment check is the one Starlette's ownStaticFiles.lookup_pathuses (realpath+commonpath), so a symlink insidestatic_pathpointing outside it is also rejected.Nested paths and an explicit
static_pathabove the app dir (e.g.static_path='../..', as in the existing tests) are unaffected. Only..within the request path is rejected.Types of changes
Checklist
nbdev_test --path nbs/api/00_core.ipynb). Both new assertions fail on unpatchedmain.