Notebook.remove and del_cells: remove cells by id or held cell - #923
Open
ncoop57 wants to merge 1 commit into
Open
Notebook.remove and del_cells: remove cells by id or held cell#923ncoop57 wants to merge 1 commit into
Notebook.remove and del_cells: remove cells by id or held cell#923ncoop57 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notebook.remove(*ids)removes cells by id, index, or heldNbCelland returns them.del_cells(path, *ids)is its path-taking twin: it removes, saves, and returnsCellRowsnapshots.movenow callsremove.Why
del nb[k]removes one cell by id or index. It cannot remove several cells in one call, and it cannot pick between two cells that share an id. nbdev's merge driver leaves a notebook that way after a conflict: both versions of the cell keep the original id, between marker cells.Changes
nbs/13_nbio.ipynb:removeafter thedel nbo[0]lesson, with a lesson cell that removes one cell by id prefix and one by held object.movedelegates to it.del_cellsafter thefind_cellstwin, whereCellRowis defined, with a lesson cell on a temporary notebook.fastcore/editskill.py:del_cellsin the import and__all__.fastcore/nbio.py,fastcore/_modidx.py: regenerated.