Serialize BCL values without reflection - #579
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Common framework values still fell back to reflection under IL2CPP.
What:
Refs #399
Refs #343
Note
Medium Risk
Changes serialization wire compatibility and facade resolution for common save-game types; behavior is heavily tested against protobuf-net but any custom
DateTimeformatter override must still satisfy root-marshal rules.Overview
Adds reflection-free WallstopProto support for
DateTime,TimeSpan,Guid, anddecimal, using protobuf-net’s BCL wire shapes so bytes match both oracle majors (2.4.9 and 3.2.56).Runtime: New
WProtoBclformatters plus root marshals register with the existing built-in bootstrap.WProtoFacaderoutes BCL roots through the root wrapper; generic/member paths treat these as last-wins scalars (not merged sub-messages) and omit defaultTimeSpan/Guid/decimallike protobuf-net, while still writingDateTime.MinValuewhen needed.Generator:
Shaperesolves the four types viaWProtoFormatterProvider;DateTimeOffsetstays WPROTO003. Map keys may use the supported BCL types.Tests & docs:
BclDifferentialTestsand expanded generator contracts pin oracle parity, golden hex, map keys, malformed payloads, and genericBox<T>closures; changelog and serialization docs list the new built-ins.Reviewed by Cursor Bugbot for commit 2250c7c. Bugbot is set up for automated code reviews on this repo. Configure here.