Fix Asset Store release staging - #474
Merged
Eli Pinkerton (wallstop) merged 1 commit intoAug 28, 2026
Merged
Conversation
This was referenced Aug 28, 2026
Contributor
Performance NumbersMeasured commit: Benchmark methodology and execution profile are unchanged; the historical Standalone comparison is diagnostic regression smoke. Historical Standalone deltaDelta direction: + is better; - is worse.
Current TargetMap evidenceThese raw rows are current-run diagnostics. Use fresh bracketed controls before accepting a micro-optimization. |
Eli Pinkerton (wallstop)
force-pushed
the
ci/session-246-asset-store-staging
branch
from
August 28, 2026 20:01
8346d70 to
41ed20e
Compare
Eli Pinkerton (wallstop)
deleted the
ci/session-246-asset-store-staging
branch
August 28, 2026 20:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Unity documents interactive Editor workflows for classic and UPM Asset Store publishing. It does not document a supported non-interactive upload API or service credential.
The release workflow staged an operator artifact, but uploaded it after npm publication. Its generator did not reject corrupt or stale store media, tag drift, or changelog drift. The UPM procedure also lacked a complete, supported acceptance test for per-version notes.
What changed
asset-store-submissionartifact before npm publication.How we know
npm test: 524 passed, 0 failed.npm run validate:all: passed.npm packrehearsal generated the ten-file v3.3.0 submission artifact.Remaining limitation
The authenticated Asset Store upload remains interactive. The workflow does not call undocumented endpoints, harvest Unity ID sessions, or store publisher credentials.
Progresses #399.
Prepares the owner-run experiment for #403.
Note
Medium Risk
Changes reorder the release publish job and add strict pre-npm gates on store collateral; a bad media hash or changelog drift blocks publication, but npm/GitHub release semantics are otherwise unchanged.
Overview
Release workflow now uploads the
asset-store-submissionartifact immediately after assembly and before npm publish, so a successful registry step cannot run without the operator payload being available.asset-store-submission.jsgains fail-fast checks (release checksums, tag vspackage.jsonversion,_upm.changelogvsCHANGELOG.md, PNG structure/dimensions, and pinned SVG/PNG hashes). It emitsEXPECTED-UPM-FIELDS.jsonand expands classic/UPM checklists to match Unity’s documented Validator/Uploader flows and Package Manager Version History acceptance for per-version notes.The quarantined research workflow fetches five official Unity publishing URLs into artifacts and fails when any page is missing or unrecognized, instead of printing a static risk brief.
Ops/runbook docs are aligned with the new artifact contents, staging order, media hash lock procedure, and manual UPM verification steps; tests assert workflow ordering and the new validation paths.
Reviewed by Cursor Bugbot for commit 41ed20e. Bugbot is set up for automated code reviews on this repo. Configure here.