Skip to content

Add missing build number to backend-version#4174

Merged
Magnusrm merged 1 commit into
mainfrom
fix/add-missing-build-number
May 11, 2026
Merged

Add missing build number to backend-version#4174
Magnusrm merged 1 commit into
mainfrom
fix/add-missing-build-number

Conversation

@Magnusrm
Copy link
Copy Markdown
Contributor

@Magnusrm Magnusrm commented May 6, 2026

Description

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* and backport* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Summary by CodeRabbit

  • Chores
    • Updated minimum application version requirement for payment webhook functionality to version 8.12.0.253.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 6, 2026

📝 Walkthrough

Walkthrough

FEATURE_VERSION_MAP.PAYMENT_WEBHOOK was updated from '8.12.0' to '8.12.0.253'. This raises the minimum application version threshold required for payment webhook feature support checks to succeed.

Changes

Payment Webhook Version Requirement

Layer / File(s) Summary
Version Constant
src/utils/versioning/versions.ts
FEATURE_VERSION_MAP.PAYMENT_WEBHOOK minimum version updated from '8.12.0' to '8.12.0.253', increasing the version threshold for appSupportsPaymentWebhooks.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning PR description is largely a template with minimal actual content; the Description section is empty, and the related issue placeholder is unfilled. Fill in the Description section with a non-technical summary of changes, provide the related issue number, and ensure all QA checkboxes are properly documented.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add missing build number to backend-version' directly summarizes the main change: updating FEATURE_VERSION_MAP.PAYMENT_WEBHOOK from '8.12.0' to '8.12.0.253'.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/add-missing-build-number

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@Magnusrm Magnusrm marked this pull request as ready for review May 7, 2026 07:21
@Magnusrm Magnusrm added kind/bug Something isn't working backport-ignore This PR is a new feature and should not be cherry-picked onto release branches labels May 7, 2026
@Magnusrm
Copy link
Copy Markdown
Contributor Author

Magnusrm commented May 7, 2026

/publish

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

PR release:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.29.2-pr.5002.add-missing-build-number.f1280d80/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.29.2-pr.5002.add-missing-build-number.f1280d80/altinn-app-frontend.js"></script>

⚙️ Building...
✅ Done!

@Magnusrm Magnusrm added the squad/utforming Issues that belongs to the named squad. label May 11, 2026
@Magnusrm Magnusrm moved this to 🔎 In review in Team Altinn Studio May 11, 2026
Copy link
Copy Markdown
Contributor

@walldenfilippa walldenfilippa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good! 🥳

@Magnusrm Magnusrm merged commit 9f29c86 into main May 11, 2026
24 of 27 checks passed
@github-project-automation github-project-automation Bot moved this from 🔎 In review to ✅ Done in Team Altinn Studio May 11, 2026
@Magnusrm Magnusrm deleted the fix/add-missing-build-number branch May 11, 2026 11:01
@Magnusrm Magnusrm added the ignore-for-release Pull requests to be ignored in release notes label May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-ignore This PR is a new feature and should not be cherry-picked onto release branches ignore-for-release Pull requests to be ignored in release notes kind/bug Something isn't working squad/utforming Issues that belongs to the named squad.

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants