feat: embed ACVP wrapper and public-scope reproducibility flow#1364
Conversation
Add ACVP wrapper entrypoints to clickhouse-backup and package the acvp symlink so the shipped binary can be exercised by acvptool. Add a tracked public-API-only ACVP config, reproducibility script, and documentation with pinned upstream references while aligning advertised wrapper capabilities with the supported public Go crypto scope. Co-authored-by: Cursor <cursoragent@cursor.com>
bc467e1 to
a434d4f
Compare
|
ACVP test crypto library, and don't test clickhouse-backup itself, let's close this PR |
|
@Slach, closing is ok. But your provided reason is invalid. The PR never claimed to test clickhouse-backup's application logic (backup/restore, manifests, storage backends). It runs ACVP against the cryptographic primitives as compiled into the shipped binary. In Go, crypto/tls, crypto/aes, crypto/sha*, crypto/ecdsa, crypto/hmac, etc. are statically linked into the So "ACVP tests the crypto library, not clickhouse-backup" conflates source-level scope with binary-level scope; |
|
@vzakaznikov who will run |
It is useful to any user of the The point is not that every user needs to run |
Coverage Report for CI Build 25867591742Coverage at 63.029% (no base build to compare)Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Summary
clickhouse-backupbinary with two entry points: argv0 dispatch viaclickhouse-backup-acvpand CLI dispatch viaclickhouse-backup acvp.pkg/acvpwrapperimplementation plus tests, and package theclickhouse-backup-acvpsymlink in Linux package builds so the wrapper can be exercised withacvptoolagainst the same binary artifact.pkg/acvpwrapper/acvp_test_fips140v1.26.public.config.json,run.sh,README.md) with pinned upstream references and reproduction guidance.getConfigcapabilities.Test plan
docker run --rm -v "$PWD:/work" -w /work golang:1.26-alpine sh -lc 'export PATH=$PATH:/usr/local/go/bin && go test ./...'bash pkg/acvpwrapper/run.sh(expected output includes38 ACVP tests matched expectations)Made with Cursor