Skip to content

fix: keep combobox popovers anchored on scroll (#296)#305

Closed
BorisTyshkevich wants to merge 1 commit into
mainfrom
fix/combobox-scroll-anchor-296
Closed

fix: keep combobox popovers anchored on scroll (#296)#305
BorisTyshkevich wants to merge 1 commit into
mainfrom
fix/combobox-scroll-anchor-296

Conversation

@BorisTyshkevich

Copy link
Copy Markdown
Collaborator

What & why

Closes #296. Open shared combobox popovers now reposition on capture-phase document scroll events, which keeps their fixed listboxes aligned while the Workbench variable strip or Dashboard filter strip scrolls horizontally. The listener is attached only while a combobox is open and is removed by the common close path.

Validation

  • npm test passes, including 100/100/100/100 coverage for src/ui/combobox.ts
  • npm run build succeeds
  • npm run test:e2e is environment-blocked: all browsers exit with SIGTRAP at launch before loading app code; a forced Chromium reinstall is blocked because cdn.playwright.dev is not allowlisted.

Checklist

Open shared combobox popovers now reposition on capture-phase scroll events, so scrolling the Workbench variable strip or Dashboard filter strip keeps the fixed listbox aligned with its input. The listener exists only while open and is removed through the common close path.\n\nCloses #296\n\nCo-Authored-By: OpenAI Codex <noreply@openai.com>\nClaude-Session: Codex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combobox popover doesn't reposition on horizontal filter-strip scroll (broader exposure after #294)

1 participant