fix: keep combobox popovers anchored on scroll (#296)#305
Closed
BorisTyshkevich wants to merge 1 commit into
Closed
fix: keep combobox popovers anchored on scroll (#296)#305BorisTyshkevich wants to merge 1 commit into
BorisTyshkevich wants to merge 1 commit into
Conversation
Open shared combobox popovers now reposition on capture-phase scroll events, so scrolling the Workbench variable strip or Dashboard filter strip keeps the fixed listbox aligned with its input. The listener exists only while open and is removed through the common close path.\n\nCloses #296\n\nCo-Authored-By: OpenAI Codex <noreply@openai.com>\nClaude-Session: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #296. Open shared combobox popovers now reposition on capture-phase document scroll events, which keeps their fixed listboxes aligned while the Workbench variable strip or Dashboard filter strip scrolls horizontally. The listener is attached only while a combobox is open and is removed by the common close path.
Validation
Checklist