-
Notifications
You must be signed in to change notification settings - Fork 57
fix: embed altimate-core in standalone binary and rename to altimate (match npm primary) #820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0e83773
fix: embed altimate-core in standalone binary and rename to altimate …
mdesmet 32a17c0
fix: archive step matched 'win32' but key uses 'windows'
mdesmet 18dd4c6
fix: install script handles altimate.exe on windows
mdesmet 4fc156e
fix: hard-error on musl + win32-arm64 across all install paths
mdesmet 154cb6c
fix: hermetic smoke test + content-level assertion on embedded .node
mdesmet 2564abf
fix: restore _requiredExports validation in the staged-shim build path
mdesmet 85dd351
fix: resolve altimate-core platform packages via createRequire
mdesmet bfe430f
fix: postinstall musl detection — execSync silently misses non-Alpine…
mdesmet 2898d9f
fix: pipefail-safe musl detection, build-time guards, hermetic test c…
mdesmet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Pre-publish smoke test still looks for the old
altimate-code-linux-x64artifact path, which can break release verification after the binary/archive rename toaltimate.Prompt for AI agents
Tip: Review your code locally with the cubic CLI to iterate faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a bug — false positive. The path glob matches the dist subdirectory layout, not the release archive name. The build script writes binaries to
dist/@altimateai/altimate-code-<target>/bin/altimate(perbuild.ts:280-291, the per-target dir name ispkg.name + os + arch + ...=@altimateai/altimate-code-<target>). That layout is unchanged by this PR — only the archive filename produced atbuild.ts:459-468was renamed toaltimate-<target>.{zip,tar.gz}. The find pattern*altimate-code-linux-x64/bin/altimatecorrectly resolves the dist binary; locally verified withls packages/opencode/dist/@altimateai/altimate-code-darwin-arm64/bin/→ containsaltimate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! I've saved this as a new learning to improve future reviews.