Skip to content

feat: build documentation for diagrams#183

Open
arielleleon wants to merge 3 commits into
mainfrom
178-add-diagrams-to-read-the-docs
Open

feat: build documentation for diagrams#183
arielleleon wants to merge 3 commits into
mainfrom
178-add-diagrams-to-read-the-docs

Conversation

@arielleleon

@arielleleon arielleleon commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator
  • adds readthedocs for the diagrams library

📚 Documentation preview 📚: https://scicomp-docs--183.org.readthedocs.build/en/183/

@arielleleon arielleleon requested a review from dbirman June 26, 2026 21:25
@arielleleon arielleleon linked an issue Jun 26, 2026 that may be closed by this pull request
@arielleleon arielleleon marked this pull request as draft June 26, 2026 21:25
@arielleleon arielleleon marked this pull request as ready for review June 26, 2026 21:37
@dbirman

dbirman commented Jun 26, 2026

Copy link
Copy Markdown
Member

I think something needs to be tweaked, the built version (in the PR comment link) for me doesn't seem to show any of the diagrams?

Screenshot 2026-06-26 at 2 50 27 PM

The diagrams/index.md toctree referenced high_level, mid_level,
low_level, and dynamic_foraging, but those pages were never tracked,
so the published build showed the landing header with no diagrams.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@arielleleon

Copy link
Copy Markdown
Collaborator Author

@dbirman - Try now

@dbirman dbirman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently these seem mostly like reference material, since they are disconnected from the how-to guides where we have most of our docs content. I think that's okay, but I feel like they would be much more useful embedded alongside the relevant content related to each diagram. They don't need to be in-line, they could appear as hover tooltips or something, or link from that content to a page with each of the diagrams.

At a minimum it would be good to provide a text description of each diagram, and probably use the glossary system that Tom set up for definitions of systems that a user might not know in advance.

I think also in an effort to reduce clutter on the left sidebar we should put this under the AIND Resources section, and probably just rename that "Resources". I will revisit the sidebar in the future though to reduce the number of things there, so not necessary to do that now.

@arielleleon

Copy link
Copy Markdown
Collaborator Author

Currently these seem mostly like reference material, since they are disconnected from the how-to guides where we have most of our docs content. I think that's okay, but I feel like they would be much more useful embedded alongside the relevant content related to each diagram. They don't need to be in-line, they could appear as hover tooltips or something, or link from that content to a page with each of the diagrams.

At a minimum it would be good to provide a text description of each diagram, and probably use the glossary system that Tom set up for definitions of systems that a user might not know in advance.

I think also in an effort to reduce clutter on the left sidebar we should put this under the AIND Resources section, and probably just rename that "Resources". I will revisit the sidebar in the future though to reduce the number of things there, so not necessary to do that now.

Yeah - this fits. I will add some documentation and put them under the Resources section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add diagrams to read the docs

2 participants