Skip to content

Update ValveCalibration widget UI#80

Merged
bruno-f-cruz merged 5 commits into
mainfrom
refactor-valve-ui
May 20, 2026
Merged

Update ValveCalibration widget UI#80
bruno-f-cruz merged 5 commits into
mainfrom
refactor-valve-ui

Conversation

@bruno-f-cruz
Copy link
Copy Markdown
Member

Closes #62

@bruno-f-cruz bruno-f-cruz requested a review from micahwoodard May 3, 2026 17:38
@bruno-f-cruz
Copy link
Copy Markdown
Member Author

@micahwoodard, this PR now adds:

  • cancellation for the water calibration;
  • flushing is now calibrated to 5mL (rounded up in increments of 500ms)

Can you give it a final test at the rigs when you have a chance before merging? thanks!

@micahwoodard
Copy link
Copy Markdown
Collaborator

@bruno-f-cruz tested this morning and worked how expected. One minor thing, is there a way for the button to become unpressed when the draining is complete? Right now, the button stays in a pressed state even after lickspout draining is complete

@bruno-f-cruz
Copy link
Copy Markdown
Member Author

@bruno-f-cruz tested this morning and worked how expected. One minor thing, is there a way for the button to become unpressed when the draining is complete? Right now, the button stays in a pressed state even after lickspout draining is complete

Can you clarify: is it the text or the graphical representation of the bug? If the text, I can fix it; if it's a graphical issue, I have no clue since I am never setting those. Have you tried to click elsewhere in the UI to check if that goes away? Likely a UI element focus issue?

@micahwoodard
Copy link
Copy Markdown
Collaborator

Can you clarify: is it the text or the graphical representation of the bug? If the text, I can fix it; if it's a graphical issue, I have no clue since I am never setting those. Have you tried to click elsewhere in the UI to check if that goes away? Likely a UI element focus issue?

It's the button highlight, not the text. It visually looks like the button is still pressed down even after the lickspout has finished draining. I don't think clicking else where would fix because it doesn't seem to me like a focus issue. I don't think it's a bug, just a user quality of life thing. If you don't think you can change then I think it's fine for the time being

@bruno-f-cruz
Copy link
Copy Markdown
Member Author

Can you clarify: is it the text or the graphical representation of the bug? If the text, I can fix it; if it's a graphical issue, I have no clue since I am never setting those. Have you tried to click elsewhere in the UI to check if that goes away? Likely a UI element focus issue?

It's the button highlight, not the text. It visually looks like the button is still pressed down even after the lickspout has finished draining. I don't think clicking else where would fix because it doesn't seem to me like a focus issue. I don't think it's a bug, just a user quality of life thing. If you don't think you can change then I think it's fine for the time being

I am sure we could figure out a way to change it programatically, I am just confused why it happens in the first place. That button is the same as the other 50 in the UI haha

@bruno-f-cruz bruno-f-cruz merged commit 8382bad into main May 20, 2026
5 checks passed
@bruno-f-cruz bruno-f-cruz deleted the refactor-valve-ui branch May 20, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI Functionality for draining lickspouts

2 participants