Skip to content

[ALICE3] Fix ALICE 3 DQ datamodel naming - #17252

Merged
njacazio merged 3 commits into
AliceO2Group:masterfrom
axti98:FixDatamodel
Jul 29, 2026
Merged

[ALICE3] Fix ALICE 3 DQ datamodel naming#17252
njacazio merged 3 commits into
AliceO2Group:masterfrom
axti98:FixDatamodel

Conversation

@axti98

@axti98 axti98 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor
  1. Move datamodel definition to ALICE3 folder
  2. Rename tables to fix merger error

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 79 errors, ⚠️ 43 warnings, 🔕 0 disabled

@axti98
axti98 marked this pull request as ready for review July 29, 2026 15:04
@njacazio
njacazio enabled auto-merge (squash) July 29, 2026 16:22
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c8b4c16 at 2026-07-29 20:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 40 errors and 2 warnings.'
Found 40 errors and 2 warnings.
++ [[ 40 -gt 0 ]]
++ cat /sw/BUILD/52358ab1a2945a40b0954da8eda8ea15592e386e/O2Physics-code-check/errors.txt
ALICE3/DataModel/ReducedTablesAlice3.h:154:32: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:146:34: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:146:63: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:250:30: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:257:33: error: the parameter 'histClasses' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:306:67: error: narrowing conversion from 'double' to 'Int_t' (aka 'int') [bugprone-narrowing-conversions,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:312:11: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:339:48: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:357:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:400:17: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:401:81: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:418:8: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:429:53: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:433:34: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:437:8: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:440:50: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:463:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:464:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:465:5: error: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:472:25: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:483:59: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:488:32: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:491:80: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:493:12: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:496:12: error: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:502:26: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:571:21: error: implicit conversion 'uint32_t' (aka 'unsigned int') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:572:102: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:583:26: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:614:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:631:9: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:653:28: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:670:28: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:679:7: error: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:680:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:693:13: error: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:694:12: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/TableProducer/alice3-dq-table-maker.cxx:698:10: error: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast,-warnings-as-errors]
ALICE3/Tasks/alice3-dq-efficiency.cxx:334:30: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
ALICE3/Tasks/alice3-dq-efficiency.cxx:1613:29: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/52358ab1a2945a40b0954da8eda8ea15592e386e/O2Physics-code-check/warnings.txt
[0 more errors; see full log]

Full log here.

@njacazio
njacazio merged commit 399f23c into AliceO2Group:master Jul 29, 2026
13 of 15 checks passed
@vkucera

vkucera commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

@axti98 You did not move the data model, you just copied it. The original PWGDQ/DataModel/ReducedTablesAlice3.h file is still there, unused.

@axti98

axti98 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

@vkucera It was removed in #17262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants