Skip to content

[PWGLF] Simplify particle validation logic #17189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
njacazio wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −24
Draft

[PWGLF] Simplify particle validation logic #17189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcfbd3c
Simplify particle validation logic
njacazio Jul 24, 2026
4515c81
Add particle charge and rapidity checks in prediction
romainschotter Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 3 additions & 24 deletions PWGLF/Tasks/QC/mcParticlePrediction.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,9 +496,9 @@ struct McParticlePrediction {
continue;
}

// if (!particle.isPhysicalPrimary()) {
// continue;
// }
if (!particle.isPhysicalPrimary()) {
continue;
}

TParticlePDG* p = pdgDB->GetParticle(particle.pdgCode());
if (p) {
Expand All @@ -513,27 +513,6 @@ struct McParticlePrediction {
continue;
}

// Check if particle has daughters (not a final state particle)
auto daughters = particle.daughters_as<aod::McParticles>();
bool isValid = false;

if (daughters.size() > 0) {
isValid = true;
for (const auto& daughter : daughters) {
if (!daughter.isPhysicalPrimary()) {
isValid = false;
break;
}
}
} else {
// Final state particle - check if particle itself is physical primary
isValid = particle.isPhysicalPrimary();
}

if (!isValid) {
continue;
}

histos.fill(HIST("particles/vtx/x"), particle.vx());
histos.fill(HIST("particles/vtx/y"), particle.vy());
histos.fill(HIST("particles/vtx/z"), particle.vz() - mcCollision.posZ());
Expand Down
Loading