[PWGHF] feat(taskLcToK0sP): add THnSparse with ML scores, align with taskLc patterns#16492
Conversation
Please consider the following formatting changes to AliceO2Group#14467
Please consider the following formatting changes to AliceO2Group#15187
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#16492
|
Fix the reported issues. |
Please consider the following formatting changes to AliceO2Group#16492
Please consider the following formatting changes to AliceO2Group#16492
…atterns Add THnSparse support for Λc→K0sP analysis with BDT scores (Data, MC Rec, MC Gen). Add process functions for standard/ML with FT0C/FT0M centrality estimators. Refactor code structure to align with taskLc.cxx.
Please consider the following formatting changes to AliceO2Group#16492
|
@dongfangqingxin Thanks for the fixes. You have overwritten the formatting changes four times. Please learn how to update your local branch and/or how to format your local changes automatically to avoid it. |
Hi @vkucera Thanks for the heads-up and sorry for the back-and-forth. I've installed clang-format locally now, will make sure to run it before pushing next time. |
You don't need to install and run it separately, if you're using the pre-commit hooks. |
Ah, I see — thanks for the tip! I hadn't set up the pre-commit hooks. I'll activate them now to avoid this in the future. |
|
Thanks @dongfangqingxin! The changes are good to me! |
…taskLc patterns (AliceO2Group#16492) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
|
You are supposed to verify your includes. |
Hi @vkucera, Thanks for your comments. I didn't get these warnings on my machine, but I believe they can be fixed by adding the following includes: I will push a commit and see if the CI passes. Please let me know if you have any further suggestions. |
How did you verify the list of includes? |
|
That is not how you are supposed to do that. Follow the instructions. https://aliceo2group.github.io/analysis-framework/docs/tools/#cleaning-include-statements-and-using-statements |
Hi @vkucera Thank you very much for the clarification and guidance. I will follow the instructions in the documentation to properly clean up the include statements. Then I will update in the new PR once I have done it correctly. |
…taskLc patterns (AliceO2Group#16492) Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Add THnSparse support for Λc→K0sP analysis with BDT scores (Data, MC Rec, MC Gen). Add process functions for standard/ML with FT0C/FT0M centrality estimators. Refactor code structure to align with taskLc.cxx."