[PWGLF] Optionally disable phi online efficiency + extended pt axes for MCGen#15794
Merged
mpuccio merged 2 commits intoAliceO2Group:masterfrom Apr 15, 2026
Merged
[PWGLF] Optionally disable phi online efficiency + extended pt axes for MCGen#15794mpuccio merged 2 commits intoAliceO2Group:masterfrom
mpuccio merged 2 commits intoAliceO2Group:masterfrom
Conversation
scannito
requested review from
alibuild,
mpuccio,
omvazque and
skundu692
as code owners
scannito
requested review from
ercolessi,
lhusova and
romainschotter
as code owners
|
O2 linter results: ❌ 3 errors, |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the phi–strangeness correlation analysis to (a) allow optionally skipping the Phi efficiency correction while still applying associated-particle efficiencies, and (b) extend MCGen pT binning / optionally bypass MCGen pT thresholds for closure studies.
Changes:
- Added “extended” variable-width pT axes (including 0) for MCGen closure histograms (Phi/K0S/Pi).
- Refactored efficiency configurables into a group and introduced
applyPhiEfficiencyto optionally avoid loading/applying the Phi efficiency map. - Added
bypassPtCutfor MCGen closure particle collection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| PWGLF/Tasks/Strangeness/phiStrangeCorrelation.cxx | Adds extended MCGen pT axes, introduces applyPhiEfficiency, and adds bypassPtCut for MCGen closure. |
| PWGLF/TableProducer/Strangeness/phiStrangeCorrelator.cxx | Updates pion PID-rejection configurables and refactors hadron/electron rejection logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mpuccio
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.