Skip to content

[PWGCF] FemtoUniverse: Add ITS PID table in DataModel, fill related PIDNsigmas and QA plots#15772

Merged
prchakra merged 5 commits intoAliceO2Group:masterfrom
prchakra:itspid
Apr 15, 2026
Merged

[PWGCF] FemtoUniverse: Add ITS PID table in DataModel, fill related PIDNsigmas and QA plots#15772
prchakra merged 5 commits intoAliceO2Group:masterfrom
prchakra:itspid

Conversation

@prchakra
Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 14, 2026

O2 linter results: ❌ 50 errors, ⚠️ 42 warnings, 🔕 14 disabled

@github-actions github-actions bot changed the title FemtoUniverse: Add ITS PID table in DataModel, fill related PIDNsigmas and QA plots [PWGCF] FemtoUniverse: Add ITS PID table in DataModel, fill related PIDNsigmas and QA plots Apr 14, 2026
@vkucera vkucera marked this pull request as draft April 14, 2026 22:28
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 14, 2026

@prchakra Can you please explain why is your PR full of broken lines and how come that your commits are authored by alibuild?

@prchakra
Copy link
Copy Markdown
Collaborator Author

@vkucera The broken lines arrived after executing the "clang-format" tool, fixing it now! Regarding your second query, I found out that the username is not set at my local repo (thanks for pointing this out), will fix it!

@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 14, 2026

Can you please describe how exactly was clang-format executed?

@prchakra
Copy link
Copy Markdown
Collaborator Author

I kept the edited files inside a different directory outside alice and ran find . -iname "*.h" -o -iname "*.cxx" | xargs clang-format -style=file -i there. This created the issue.

@prchakra prchakra marked this pull request as ready for review April 15, 2026 07:15
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 15, 2026

I kept the edited files inside a different directory outside alice and ran find . -iname "*.h" -o -iname "*.cxx" | xargs clang-format -style=file -i there. This created the issue.

OK that explains it. I don't see any reason why you would want to take your files outside the repository but please never do that. There is also no reason to run clang-format like this. Stick to the official instructions.

@prchakra prchakra enabled auto-merge (squash) April 15, 2026 08:11
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @prchakra.

@prchakra prchakra merged commit 9204373 into AliceO2Group:master Apr 15, 2026
11 of 13 checks passed
@prchakra prchakra deleted the itspid branch April 15, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants