[PWGLF] Changes to accomodate online mult-integrated efficiency correction + electron rejection

[scannito]

No description provided.

[github-actions]

O2 linter results: ❌ 6 errors, ⚠️ 16 warnings, 🔕 0 disabled

[Copilot]

Pull request overview

This PR updates the Phi–strangeness correlation workflow to support mult-integrated (2D) efficiency maps and introduces an electron-rejection step in pion track production.

Changes:

• Extend efficiency-map handling to accept either TH2 or TH3 maps from CCDB and update weighting logic accordingly.
• Add configurable toggles for enabling/disabling individual associated-particle correlations (K0S / Xi / pion).
• Add an electron-rejection step to the pion track producer and simplify the pion PID “in nσ region” helper signature.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File	Description
PWGLF/Tasks/Strangeness/phiStrangeCorrelation.cxx	Introduces TH2/TH3 efficiency map support, correlation enable toggles, updated weighting/selection guards, and MC-closure bookkeeping updates.
PWGLF/TableProducer/Strangeness/phiStrangeCorrelator.cxx	Adds electron rejection to pion track PID hypothesis rejection.
PWGLF/DataModel/LFPhiStrangeCorrelationTables.h	Updates the pion InNSigmaRegion dynamic column signature to remove the pT/threshold dependency.

Comments suppressed due to low confidence (1)

PWGLF/Tasks/Strangeness/phiStrangeCorrelation.cxx:1110

• The new doXiCorrelation/kXi plumbing is incomplete: xiParticles is never filled (no PDG selection for Xi in the MC loop), so enabling Phi–Xi correlations will silently produce no output while still attempting to load an efficiency map. Either implement Xi candidate collection (and corresponding histograms) or remove/disable the Xi option until it is supported.

    std::vector<MiniParticle> phiParticles;
    std::vector<MiniParticle> k0sParticles;
    std::vector<MiniParticle> xiParticles;
    std::vector<MiniParticle> pionParticles;

    auto inYAcceptance = [&](const auto& mcParticle) {
      return std::abs(mcParticle.y()) <= yConfigs.cfgYAcceptance;
    };

    // Preliminary loop to fill vectors of particles of interest for the current event, applying pt and y cuts
    for (const auto& mcParticle : mcParticles) {
      if (!inYAcceptance(mcParticle))
        continue;

      switch (std::abs(mcParticle.pdgCode())) {
        case o2::constants::physics::Pdg::kPhi:
          if (eventSelectionType == 0 && mcParticle.pt() >= minPtMcGenConfigs.minPhiPt)
            phiParticles.emplace_back(mcParticle.pt(), mcParticle.y(), mcParticle.phi());
          break;
        case PDG_t::kK0Short:
          if (mcParticle.isPhysicalPrimary() && mcParticle.pt() >= minPtMcGenConfigs.v0SettingMinPt)
            k0sParticles.emplace_back(mcParticle.pt(), mcParticle.y(), mcParticle.phi());
          break;
        case PDG_t::kPiPlus:
          if (mcParticle.isPhysicalPrimary() && mcParticle.pt() >= minPtMcGenConfigs.cMinPionPtcut)
            pionParticles.emplace_back(mcParticle.pt(), mcParticle.y(), mcParticle.phi());
          break;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

xiParticles is added for Phi–Xi closure, but the MC-particle loop below does not currently push any Xi candidates into this vector (no PDG handling), so enabling Xi correlations will still produce empty Phi–Xi closure output. Either populate xiParticles in the PDG loop (with appropriate selection cuts) or remove/disable the Xi path until implemented.

[Copilot]

doXiCorrelation is exposed as a user-facing toggle, but this task currently has no Xi candidate input/selection and no Xi correlation loops in the data/MC-reco processing paths (only K0S and pion are actually used). As a result, enabling this option will not produce any Phi–Xi output (and it still attempts to load a Xi efficiency map). Either implement the full Phi–Xi chain (tables, selection, histogram definitions, filling) or remove/disable this configurable until Xi support is complete.

Suggested change

	Configurable<bool> doXiCorrelation{"doXiCorrelation", false, "Enable Phi-Xi correlation"};
	// Xi correlation is not yet implemented in this task (no Xi candidate input/selection
	// and no Phi-Xi correlation filling in the processing paths), so keep it hard-disabled
	// until the full Xi chain is added.
	const bool doXiCorrelation = false;

[Copilot]

assocParticleLabels now includes Xi, and the closure code later constructs histogram keys from these labels (e.g. phiXi/...) when doXiCorrelation is enabled, but the registry only defines closure histograms for K0S and pion here. Either add the corresponding phiXi/... histograms as part of completing Xi support, or remove Xi from the label/config machinery until the feature is implemented end-to-end.