[PWGHF] Add MC efficiency calculation and extend electron–hadron correlation table#15735
Open
rashigupt wants to merge 15 commits intoAliceO2Group:masterfrom
Open
[PWGHF] Add MC efficiency calculation and extend electron–hadron correlation table#15735rashigupt wants to merge 15 commits intoAliceO2Group:masterfrom
rashigupt wants to merge 15 commits intoAliceO2Group:masterfrom
Conversation
…ection table Introduce MC changes for efficiency estimation and extend electron selection table with additional variables
rashigupt
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
github-actions
bot
changed the title
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for dd9880b at 2026-04-12 16:11: Full log here. |
Collaborator
|
@rashigupt Your PR does not compile! How did you test your changes? |
Collaborator
|
Error while checking build/O2Physics/o2 for 612fc0e at 2026-04-13 14:06: Full log here. |
Collaborator
|
@rashigupt Can you please explain your testing workflow? You made the PR ready for review and it failed the compilation again. |
Contributor
Author
s
sorry @vkucera this won’t happen again in the future. |
Contributor
Author
|
hi @vkucera ,have verified that the code compiles successfully in my local environment; however, I am not sure why it is failing here |
Contributor
Author
|
hi @vkucera , I have verified that the code compiles successfully in my local environment; however, I am not sure why it is failing here. |
Collaborator
If you are referring to the macOS build, that is unrelated. |
apalasciano
requested changes
Apr 14, 2026
Collaborator
There was a problem hiding this comment.
Dear Rashi, thanks for the PR.
I have one comment: instead of explicitly looking for mother, grandmothers, and so on, you could use the function:
getCharmHadronOrigin
This does everything automatically (just flag searchUpToQuark=true), returning an integer (0: none, 1: prompt, 2: nonprompt), which seems to me what you need.
This would simplify your code a lot
vkucera
reviewed
Apr 14, 2026
| if (mcAssoParticle.has_mothers()) { | ||
| auto const& motherAsso = mcAssoParticle.template mothers_first_as<aod::McParticles>(); | ||
|
|
||
| if (std::abs(motherAsso.pdgCode()) == kEtaLocal || std::abs(motherAsso.pdgCode()) == kPi0 || std::abs(motherAsso.pdgCode()) == kGamma) { |
Collaborator
There was a problem hiding this comment.
Remove kEtaLocal and use kEta instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces MC-based changes for efficiency estimation and extends electron-related tables.
Changes:
electronSelectionWithTPCEMCal:
correlatorHfeHadron: