[PWGJE] Rename Ds jet task (jetDsSpectrumAndSubstructure to jetDsSpecSubs) and add THnSparse histograms#15733
Closed
monamelop wants to merge 4 commits intoAliceO2Group:masterfrom
Closed
[PWGJE] Rename Ds jet task (jetDsSpectrumAndSubstructure to jetDsSpecSubs) and add THnSparse histograms#15733monamelop wants to merge 4 commits intoAliceO2Group:masterfrom
monamelop wants to merge 4 commits intoAliceO2Group:masterfrom
Conversation
…Subs) and add THnSparse histograms
monamelop
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern,
nzardosh and
raymondEhlers
as code owners
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Hi @monamelop , could you please give some info on this and #15727 PR that you have open? Why are they separate? Also please rebase your O2Physics to the latest changes. You are changing parts of the c-make files for other tasks and also changing the headers in your own tasks which should not be changed. Thanks |
Contributor
Author
|
Hi, Thanks for the feedback. This PR has been closed and superseded by a clean version: #15749 In the new PR, I have:
Please refer to #15749 for the updated version. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename Ds jet task (jetDsSpectrumAndSubstructure to jetDsSpecSubs) and add THnSparse histograms.