Skip to content

[PWGCF] added a process function for mixed event combinatorial bkg for phi#15710

Merged
jgrosseo merged 5 commits intoAliceO2Group:masterfrom
prottayCMT:master
Apr 14, 2026
Merged

[PWGCF] added a process function for mixed event combinatorial bkg for phi#15710
jgrosseo merged 5 commits intoAliceO2Group:masterfrom
prottayCMT:master

Conversation

@prottayCMT
Copy link
Copy Markdown
Collaborator

@prottayCMT prottayCMT commented Apr 10, 2026

No description provided.

@github-actions github-actions bot changed the title added a process function for mixed event combinatorial bkg for phi [PWGCF] added a process function for mixed event combinatorial bkg for phi Apr 10, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026 •
edited
Loading

O2 linter results: ❌ 64 errors, ⚠️ 26 warnings, 🔕 0 disabled

jgrosseo
jgrosseo reviewed Apr 10, 2026
View reviewed changes
Comment thread PWGCF/TableProducer/filter2Prong.cxx Outdated
// #define FLOAT_PRECISION 0xFFFFFFF0
#define O2_DEFINE_CONFIGURABLE(NAME, TYPE, DEFAULT, HELP) Configurable<TYPE> NAME{#NAME, DEFAULT, HELP};

namespace o2::aod
Copy link
Copy Markdown
Contributor

@jgrosseo jgrosseo Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to the data model, then we do not need to have it twice

Copy link
Copy Markdown
Collaborator Author

@prottayCMT prottayCMT Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Comment thread PWGCF/TableProducer/filter2Prong.cxx Outdated

for (auto it = pairs.begin(); it != pairs.end(); it++) {
auto& [collision1, tracks1, collision2, tracks2] = *it;
// float multiplicity = getMultiplicity(collision1);
Copy link
Copy Markdown
Contributor

@jgrosseo jgrosseo Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the commented lines

Copy link
Copy Markdown
Collaborator Author

@prottayCMT prottayCMT Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Comment thread PWGCF/TableProducer/filter2Prong.cxx
// float multiplicity = getMultiplicity(collision1);
// int bin = configurableBinningDerived.getBin(std::tuple(collision1.posZ(), multiplicity));
// float eventWeight = 1.0f / it.currentWindowNeighbours();
if (!(collision1.sel8() &&
Copy link
Copy Markdown
Contributor

@jgrosseo jgrosseo Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may later need to run it with a larger cfgNoMixedEvents because we skip events here

Copy link
Copy Markdown
Collaborator Author

@prottayCMT prottayCMT Apr 10, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes currently I am using the same set of event cuts as we applied for the same events....do you want to remove these?

Comment thread PWGCF/TableProducer/filter2Prong.cxx
for (const auto& cftrack1 : tracks1) {
const auto& p1 = tracksP.iteratorAt(cftrack1.trackId() - tracksP.begin().globalIndex());

if (p1.sign() != 1) {
Copy link
Copy Markdown
Contributor

@jgrosseo jgrosseo Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cftrack2.track().sign() does not work?

Copy link
Copy Markdown
Collaborator Author

@prottayCMT prottayCMT Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it works but as I am using the p1 for the rest of the logic (tracks cuts, pid...) i am using this object consistently

Copy link
Copy Markdown
Contributor

@jgrosseo jgrosseo Apr 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const auto& p1 = cftrack1.track()

Copy link
Copy Markdown
Collaborator Author

@prottayCMT prottayCMT Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Comment thread PWGCF/TableProducer/filter2Prong.cxx Outdated
Comment on lines +877 to +878
if (selectionPID3(p1) && selectionPID3(p2)) {
if (selectionSys(p1, false, false) && selectionSys(p2, false, false)) {
Copy link
Copy Markdown
Contributor

@jgrosseo jgrosseo Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the selections before the computations (line 867)

Copy link
Copy Markdown
Collaborator Author

@prottayCMT prottayCMT Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

jgrosseo
jgrosseo previously approved these changes Apr 13, 2026
View reviewed changes
@jgrosseo jgrosseo marked this pull request as ready for review April 13, 2026 14:44
@jgrosseo jgrosseo enabled auto-merge (squash) April 13, 2026 14:44
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 13, 2026

Error while checking build/O2Physics/o2 for 9e63844 at 2026-04-13 16:52:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGCF/TableProducer/filter2Prong.cxx:782:95: error: unused parameter 'tracksP' [-Werror=unused-parameter]
ninja: build stopped: subcommand failed.

Full log here.

@jgrosseo jgrosseo merged commit 58d53ae into AliceO2Group:master Apr 14, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jgrosseo jgrosseo jgrosseo approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner

@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner

@otonvd otonvd Awaiting requested review from otonvd otonvd is a code owner

@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner

Assignees

No one assigned

Labels

datamodel pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prottayCMT @alibuild @jgrosseo