[PWGEM/Dilepton] update matchingMFT.cxx #14577
Merged
Annotations
9 errors and 2 notices
|
|
|
|
|
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L59
Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
|
|
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L1
Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
|
|
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L1
Specify task name only when it cannot be derived from the struct name. Only append to the default name.
|
|
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L1120
Device names matching-mft and matching-m-f-t generated from the specified task name matching-mft and from the struct name matchingMFT, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to MatchingMft and removing TaskName.
|
|
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L422
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L279
Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
|
|
PWGEM/Dilepton/Tasks/matchingMFT.cxx#L422
Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
|
|
|
|
|
The logs for this run have expired and are no longer available.
Loading