[PWGCF] update on ese#11530
Merged
shouqiye merged 11 commits intoAliceO2Group:masterfrom Jun 10, 2025
Merged
Conversation
zhengqi-w
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 0 errors, |
Collaborator
|
Error while checking build/O2Physics/o2 for 6950409 at 2025-06-10 09:30: Full log here. |
[PWGCF] Please consider the following formatting changes to AliceO2Group#11530
[PWGCF] Please consider the following formatting changes to AliceO2Group#11530
shouqiye
approved these changes
Jun 10, 2025
jinhyunni
pushed a commit
to jinhyunni/O2Physics
that referenced
this pull request
Jun 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
hernasab
pushed a commit
to hernasab/O2Physics
that referenced
this pull request
Jun 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
prottayCMT
pushed a commit
to prottayCMT/O2Physics2024
that referenced
this pull request
Jun 12, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
lietava
pushed a commit
to lietava/O2Physics
that referenced
this pull request
Jun 14, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ddobrigk
pushed a commit
to ddobrigk/O2Physics
that referenced
this pull request
Jun 14, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
alibuild
added a commit
to alibuild/O2Physics
that referenced
this pull request
Aug 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker
pushed a commit
to jloemker/O2Physics
that referenced
this pull request
Nov 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
vkucera
reviewed
Apr 14, 2026
Comment on lines
+659
to
+661
| int detInd = detId * 4 + cfgnTotalSystem * 4 * (2 - 2); | ||
| int refAInd = refAId * 4 + cfgnTotalSystem * 4 * (2 - 2); | ||
| int refBInd = refBId * 4 + cfgnTotalSystem * 4 * (2 - 2); |
Collaborator
There was a problem hiding this comment.
What's the point of this?
Comment on lines
+870
to
+872
| detInd = detId * 4 + cfgnTotalSystem * 4 * (2 - 2); | ||
| refAInd = refAId * 4 + cfgnTotalSystem * 4 * (2 - 2); | ||
| refBInd = refBId * 4 + cfgnTotalSystem * 4 * (2 - 2); |
Collaborator
There was a problem hiding this comment.
What's the point of this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update on ese