Skip to content

Backends/ApMonBackend: create source field only if it exists #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertpaulp wants to merge 1 commit into
base: dev
Choose a base branch
from
+16 −8
Open

Backends/ApMonBackend: create source field only if it exists #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/Backends/ApMonBackend.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,16 @@ void ApMonBackend::sendBatch(const std::vector<reference_wrapper<const Metric>>&
const std::string_view metricName = metric.get().getName();
stringValues.emplace_back(metricName);
const char* metriNamePtr = stringValues.back().c_str();
stringValues.emplace_back(std::string(metricName) + "_src");
const char* metriNameSrcPtr = stringValues.back().c_str();
stringValues.push_back(std::move(entity));
const char* entityPtr = stringValues.back().c_str();
bool hasEntity = !entity.empty();
const char* metriNameSrcPtr = nullptr;
const char* entityPtr = nullptr;

if (hasEntity) {
stringValues.emplace_back(std::string(metricName) + "_src");
metriNameSrcPtr = stringValues.back().c_str();
stringValues.push_back(std::move(entity));
entityPtr = stringValues.back().c_str();
}

for (int i = 0; i < valueSize; ++i) {
paramNames.push_back(const_cast<char*>(metriNamePtr));
Expand All @@ -152,16 +158,18 @@ void ApMonBackend::sendBatch(const std::vector<reference_wrapper<const Metric>>&
},
}, values[i].second);

paramNames.push_back(const_cast<char*>(metriNameSrcPtr));
valueTypes.push_back(XDR_STRING);
paramValues.push_back(const_cast<char*>(entityPtr));
if (hasEntity) {
paramNames.push_back(const_cast<char*>(metriNameSrcPtr));
valueTypes.push_back(XDR_STRING);
paramValues.push_back(const_cast<char*>(entityPtr));
}
}
}

mApMon->sendTimedParameters(
const_cast<char*>(clusterName.c_str()),
const_cast<char*>(nodeName.c_str()),
totalParams, paramNames.data(), valueTypes.data(), paramValues.data(),
static_cast<int>(paramNames.size()), paramNames.data(), valueTypes.data(), paramValues.data(),
convertTimestamp(metrics[0].get().getTimestamp())
);
}
Expand Down