refactor(c++): 🎨 implementation into either source or inline files - #203
Open
robertodr wants to merge 4 commits into
Open
refactor(c++): 🎨 implementation into either source or inline files#203robertodr wants to merge 4 commits into
robertodr wants to merge 4 commits into
Conversation
robertodr
requested review from
diagonal-hamiltonian,
fpietra and
ludmilaasb
as code owners
August 5, 2026 07:33
|
Docs preview: https://pr-203.monoprop-docs.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## chore-cibuildwheel-conf #203 +/- ##
========================================================
Coverage 95.31% 95.31%
========================================================
Files 14 14
Lines 704 704
Branches 88 88
========================================================
Hits 671 671
Misses 20 20
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. |
robertodr
force-pushed
the
refactor-split-impls
branch
from
August 5, 2026 12:27
dd1ded4 to
959a78e
Compare
robertodr
changed the base branch from
chore-split-implementation
to
chore-cibuildwheel-conf
August 5, 2026 12:27
robertodr
force-pushed
the
refactor-split-impls
branch
from
August 5, 2026 14:10
8c8cd31 to
8c4a9ea
Compare
robertodr
force-pushed
the
refactor-split-impls
branch
from
August 5, 2026 14:42
8c4a9ea to
8bb5b72
Compare
Panadestein
force-pushed
the
refactor-split-impls
branch
from
August 5, 2026 15:45
8bb5b72 to
d4d25ae
Compare
robertodr
force-pushed
the
refactor-split-impls
branch
from
August 5, 2026 16:12
d4d25ae to
c5e4065
Compare
robertodr
force-pushed
the
refactor-split-impls
branch
from
August 5, 2026 17:51
c5e4065 to
64d772c
Compare
robertodr
force-pushed
the
refactor-split-impls
branch
from
August 5, 2026 19:18
64d772c to
6bde741
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
🤖 AI text below 🤖
This pull request primarily refactors and reorganizes the implementation of graph encoding and cross-rank storage logic in the
monoproplibrary. The main changes involve moving inline function implementations from headers to a new.cppfile, improving encapsulation, and cleaning up header dependencies. Additionally, a new utility function is added for parameter validation.Refactoring and Implementation Reorganization
MPGraphEncodingStorage.handMPGraphEncodingTypes.hinto a new source fileMPGraphEncoding.cpp, replacing inline functions with declarations in the headers. This improves build times and encapsulation of implementation details. [1] [2] [3] [4] [5] [6] [7]MPGraphEncoding.cppfile as part of the build.API and Dependency Cleanups
MonomialPropagator.hto a single.inlfile, further reducing header complexity.New and Improved Utilities
expected_num_paramstoValidation.cppand exposed it inValidation.h, providing a utility to determine the expected number of parameters from a mapping vector. [1] [2]MonomialPropagatorthat are now provided elsewhere.These changes improve code organization, maintainability, and build performance by isolating implementation details and reducing header dependencies.
Checklist
docs/,CONTRIBUTING.md) if neededCHANGELOG/ release notes updated if applicableAI/LLM disclosure
Important
By opening this PR I confirm that I have read CONTRIBUTING.md and I agree to the terms of the Contributor License Agreement.
Warning
If you're contributing on behalf of your employer, contact cla@algorithmiq.fi to arrange a Corporate CLA.