fix: 🐛 make number of qubits obligatory - #162
Merged
Merged
Conversation
… in the interface
ludmilaasb
marked this pull request as ready for review
August 5, 2026 09:26
ludmilaasb
requested review from
diagonal-hamiltonian,
fpietra,
ludmilaasb and
robertodr
as code owners
August 5, 2026 09:26
ludmilaasb
marked this pull request as draft
August 5, 2026 09:26
ludmilaasb
marked this pull request as ready for review
August 5, 2026 13:29
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
==========================================
+ Coverage 94.77% 97.58% +2.80%
==========================================
Files 14 14
Lines 708 745 +37
Branches 90 99 +9
==========================================
+ Hits 671 727 +56
+ Misses 22 13 -9
+ Partials 15 5 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
ludmilaasb
marked this pull request as draft
August 5, 2026 13:40
Member
|
Tests fixed, fixing the documentation |
|
Docs preview: https://pr-162.monoprop-docs.pages.dev |
robertodr
changed the title
robertodr
reviewed
Aug 5, 2026
robertodr
reviewed
Aug 5, 2026
robertodr
previously approved these changes
Aug 5, 2026
robertodr
left a comment
robertodr
left a comment
Member
There was a problem hiding this comment.
LGTM, please review the suggested removal of two comments that look like slop to me
Co-authored-by: Roberto Di Remigio Eikås <robertodr@users.noreply.github.com> Signed-off-by: Ludmila Botelho <39570941+ludmilaasb@users.noreply.github.com>
ludmilaasb
marked this pull request as ready for review
August 6, 2026 07:35
… to 100% Adds targeted unit tests for previously-untested validation and error paths in circuit.py, fermi.py, majorana.py, qiskit_conversion.py, and utils.py (new tests/test_utils.py). No functional changes. Assisted-by: ClaudeCode:claude-sonnet-5
…modes' into fix/obligatory-number-of-qubits-modes
ludmilaasb
reviewed
Aug 6, 2026
Co-authored-by: Ludmila Botelho <39570941+ludmilaasb@users.noreply.github.com> Signed-off-by: Roberto Di Remigio Eikås <robertodr@users.noreply.github.com>
robertodr
previously approved these changes
Aug 6, 2026
…b.com/Algorithmiq/monoprop into fix/obligatory-number-of-qubits-modes
Member
|
do we have an explicit test that covers Matteo's case in #160 ? EDIT yes we do |
robertodr
approved these changes
Aug 6, 2026
github-actions
Bot
added
documentation
robertodr
enabled auto-merge (squash)
August 6, 2026 09:20
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By opening this PR I confirm that I have read CONTRIBUTING.md and I agree to the terms of the Contributor License Agreement.
Summary
Makes number of qubits argument obligatory to avoid confusing interface
Closes #83
Closes #160
Changes
Checklist
docs/,CONTRIBUTING.md) if neededCHANGELOG/ release notes updated if applicableAI/LLM disclosure