Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
_get_int_envinconfig.pyand exposeLOCAL_LLM_MODEL_PATH,LOCAL_LLM_CONTEXT,LOCAL_LLM_THREADS, andLOCAL_LLM_MAX_TOKENSwith sensible defaults.services/local_llm.pyto load the model fromLOCAL_LLM_MODEL_PATH, use configuredn_ctx/n_threads, normalizemax_tokens, harden prompt handling, and provide clearer logging and error strings.services/llm.pyimport tofrom services.local_llm import ask_local_llmand preserve optional process-based execution for local LLM calls.README.md,models/README.md) to reflect Google Gemma 4 usage, update model download examples and.envguidance, and change release/version notes to v4.1.0..github/workflows/pylint.ymlto useactions/setup-python@v5and reduce the test matrix topython-version: ["3.10", "3.14"].Testing
tests/test_config.pyandtests/test_local_llm.pyand ranpytest, with the new tests passing..github/workflows/pylint.ymlto run on push withactions/setup-python@v5and the updated Python matrix so linting will execute automatically on push.Codex Task