Feature/bonus points - #39
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 8 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe task UI now uses ChangesTask UI updates
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant CreateTaskModal
participant TaskQuery
participant TaskCard
User->>CreateTaskModal: Create task
CreateTaskModal->>TaskQuery: Invalidate tasks query
TaskQuery-->>CreateTaskModal: Refresh task data
CreateTaskModal->>TaskCard: Find created task by ID
CreateTaskModal->>TaskCard: Scroll into view
TaskCard->>TaskCard: Run entry animation
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Line 123: Update the README due-date colors description for dueInfo to say
amber applies “within two days” (or explicitly state the inclusive dayDiff <= 2
boundary), while preserving the existing green and red descriptions.
In `@src/features/tasks/CreateTaskModal.tsx`:
- Around line 9-10: Make the task identity contract consistent by adding the
data-task-id attribute with task.id to the TaskRow root used by the list layout,
so scrollToTask can locate newly created tasks. Keep the existing board-card
attribute and scrollToTask behavior unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: cb1b9ac1-4cc2-4b45-9ab9-98944f49d877
📒 Files selected for processing (5)
README.mdsrc/features/tasks/CreateTaskModal.tsxsrc/features/tasks/TaskCard.tsxsrc/features/tasks/TaskList.tsxsrc/index.css
| <!-- TODO: list which bonus features I tackled, if any --> | ||
| - **Total count of tasks by column** — board column headers and list group headers both carry live counts. | ||
| - **Layout toggle (columns ↔ list)** — the desktop icon switcher and the mobile Dashboard/Task tabs drive one shared selection that survives navigation and resizes. | ||
| - **Due-date colors** — green on time, amber under two days, red overdue: one rule (`dueInfo` in `task-display.ts`) drives the card date chips, the list view's row indicators, and the list date text. The mockup only shows the red/neutral chip states; the requirement asks for three colors, and requirements outrank mockups. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Correct the due-date boundary wording.
dueInfo uses the amber tone when dayDiff <= 2. This includes tasks due today, tomorrow, and exactly two days from now. Replace “under two days” with “within two days” or document the exact boundary.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@README.md` at line 123, Update the README due-date colors description for
dueInfo to say amber applies “within two days” (or explicitly state the
inclusive dayDiff <= 2 boundary), while preserving the existing green and red
descriptions.
| function scrollToTask(id: string, attempts = 10) { | ||
| const card = document.querySelector(`[data-task-id="${id}"]`) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Make the task identity contract consistent across layouts.
scrollToTask searches for [data-task-id="${id}"]. The board card exposes this attribute, but the list view's TaskRow does not. When a user creates a task in list layout, the refresh succeeds but the polling loop never finds the row, so the new task is not scrolled into view. Add data-task-id={task.id} to the TaskRow root or use a shared anchor in both layouts. The add-task control is available in list layout, so this path is reachable. (raw.githubusercontent.com)
Proposed contract fix
--- a/src/features/tasks/TaskList.tsx
+++ b/src/features/tasks/TaskList.tsx
@@
- <div className="flex">
+ <div data-task-id={task.id} className="flex">🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/features/tasks/CreateTaskModal.tsx` around lines 9 - 10, Make the task
identity contract consistent by adding the data-task-id attribute with task.id
to the TaskRow root used by the list layout, so scrollToTask can locate newly
created tasks. Keep the existing board-card attribute and scrollToTask behavior
unchanged.
Source: MCP tools
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
1 participant
Summary by CodeRabbit
New Features
Style