Add restricted roles to Alchemy pages - #4102
Closed
sascha-karnatz wants to merge 7 commits into
Closed
Conversation
sascha-karnatz
force-pushed
the
restricted-roles
branch
from
July 27, 2026 15:44
e6eaae9 to
d7969be
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4102 +/- ##
=======================================
Coverage 98.26% 98.27%
=======================================
Files 350 351 +1
Lines 9184 9207 +23
=======================================
+ Hits 9025 9048 +23
Misses 159 159 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The configuration is (or can be) a subset of the user_roles configuration. This way every user with correct role can access a page. The default values is "member" to don't break the previous behavior for restricted pages.
Add a new restricted_roles column with a space separated list of roles, that can access a page. The default values is "member" to support the same behavior as before.
...to test that feature better in the dummy app.
Add getter and setter to the page model to split and join the group collection. Extend the set_restrictions_to_child_pages behavior to update restricted_roles as well. It was necessary to move from before_save to after_save to update restricted and restricted_roles of child pages. Otherwise inherit_restricted_status would read old data from the database.
Test if the user has the correct role to read the page. This change only affects the MemberUser permission. GuestUser can't see restricted pages and AuthorUser includes the MemberUser module. If Alchemy will be extended by other roles (like restricted_test in the Dummy app), it is necessary to create new abilities to prevent misconfigurations (like to many redirects).
This small web component allow to toggle inputs in forms based on checkbox values. The idea is to show the restricted_roles select only, if the user enabled the restricted checkbox before.
Provide a new PageRestrictedRolesSelect view component to render a select with all configured restricted_roles. The select is only visible if the restricted checkbox is enabled.
sascha-karnatz
force-pushed
the
restricted-roles
branch
from
July 29, 2026 08:06
d7969be to
cf8b482
Compare
tvdeyen
requested changes
Jul 29, 2026
tvdeyen
left a comment
tvdeyen
left a comment
Member
There was a problem hiding this comment.
I think we should call this permitted_roles. The page is restricted and the users with these roles are permitted to access the page.
Contributor
Author
|
Closing this PR in favor of #4112 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Add a restricted_roles column to the Page model to extend the restricted page behavior. This way it is possible restrict the access to pages only for a smaller set of users with a given role.
Notable changes (remove if none)
There is an addition to the MemberUser permission that is now evaluating also the
restricted_rolescolumn on the page. The default value is "member" and it should behave same way as before.Screenshots
Checklist