fix(observability): keep usage chart labels visible - #6055
Conversation
|
@kkkhs is attempting to deploy a commit to the agenta projects Team on Vercel. A member of the Team first needs to authorize it. |
|
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hey @kkkhs, thank you for the fix. Can you please sign the CLA license? After that, we can merge the PR |
Summary
Fixes #5968.
Usage charts were using a negative left margin, which pushed wider y-axis labels outside the SVG clip. This keeps the left chart margin at zero so labels like
20Kmsand$4.00stay visible.Testing
Verified locally
pnpm --filter @agenta/oss exec vitest run src/components/pages/observability/dashboard/CustomAreaChart.test.tsxpnpm exec eslint oss/src/components/pages/observability/dashboard/CustomAreaChart.tsx oss/src/components/pages/observability/dashboard/CustomAreaChart.test.tsxpnpm --filter @agenta/oss exec tsc --noEmitgit diff --checkAdded or updated tests
Added a regression test for the chart margin used by the observability usage charts.
QA follow-up
Verify the expanded Usage card with latency and cost values wide enough to produce labels such as
20Kmsor$4.00.Demo
Draft PR: demo recording pending before ready-for-review.
Checklist
Contributor Resources