Skip to content

[cleanup]: create new evaluation modal to remove hard wires#4790

Open
ashrafchowdury wants to merge 3 commits into
fe-feat/query-registryfrom
refactor/new-evaluation-modal-to-remove-hard-wires
Open

[cleanup]: create new evaluation modal to remove hard wires#4790
ashrafchowdury wants to merge 3 commits into
fe-feat/query-registryfrom
refactor/new-evaluation-modal-to-remove-hard-wires

Conversation

@ashrafchowdury

@ashrafchowdury ashrafchowdury commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What's changed??

  • Removed all the hard wire enitty steps from the modal
  • Made the steps dynamic so that we can add new steps and make steps dependent on each other
  • No UI changes anywhere
  • Only under-layer code changes have been made.

QA

  • Create auto evaluation
  • Create auto evaluation from the playground
  • Make sure the flow is as like before, no changes should be reflected

@ashrafchowdury
feat(evaluations): implement evaluation step registry and state manag…
51e70a1 
…ement

- Added a new evaluation step registry to manage application, revision, testset, evaluator, and advanced settings steps.
- Introduced state management for evaluation steps using Jotai atoms.
- Created types for evaluation steps, including context and runtime interfaces.
- Updated NewEvaluationModal to support declarative step configurations and name building.
- Removed obsolete state management files related to panel and selection.
- Enhanced evaluation payload handling to support splitting by application steps.
- Added unit tests for the evaluation step engine to validate configurations and payload composition.
@ashrafchowdury
doc(evaluations): add documentation for evaluation backend and query …
e316cf2 
…evaluation flow
@dosubot dosubot Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jun 22, 2026
@vercel

vercel Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jun 22, 2026 2:24pm

Request Review

@dosubot dosubot Bot added Frontend refactoring A code change that neither fixes a bug nor adds a feature labels Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fece61b4-4d2f-40f4-b3fe-ddb93fc91824

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/new-evaluation-modal-to-remove-hard-wires

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ashrafchowdury ashrafchowdury requested a review from ardaerzin June 22, 2026 13:47
ardaerzin
ardaerzin requested changes Jun 22, 2026
View reviewed changes

@ardaerzin ardaerzin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say while doing the cleanup we should also rename certain things, such as "app" / "application" related references. with the new capabilities and models, that step is not a mere "application" step as any workflow can be used

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Railway Preview Environment
Preview URL https://gateway-production-b70f.up.railway.app/w
Image tag pr-4790-a1c10f0
Status Failed
Railway logs Open logs
Logs View workflow run
Updated at 2026-06-22T14:34:19.865Z

ardaerzin
ardaerzin reviewed Jun 22, 2026
View reviewed changes
Comment thread web/oss/src/components/pages/evaluations/NewEvaluation/evalSteps/state.ts

export const evalStepValuesAtom = atom<Partial<EvalStepValueMap>>({})

export const evalStepValueAtomFamily = atomFamily((kind: EvalStepKind) =>

@ardaerzin ardaerzin Jun 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not used anywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ardaerzin ardaerzin ardaerzin requested changes

Assignees

No one assigned

Labels

Frontend refactoring A code change that neither fixes a bug nor adds a feature size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashrafchowdury @ardaerzin