Skip to content

fix: bound notification publishing on the lifecycle path#2254

Open
ChiragArora31 wants to merge 1 commit into
AgentWrapper:mainfrom
ChiragArora31:fix-notification-publish-timeouts
Open

fix: bound notification publishing on the lifecycle path#2254
ChiragArora31 wants to merge 1 commit into
AgentWrapper:mainfrom
ChiragArora31:fix-notification-publish-timeouts

Conversation

@ChiragArora31

Copy link
Copy Markdown
Contributor

Summary

Related to #1937.

Notification writes are persisted first, then published to live dashboard subscribers. If a publisher stalls, that publish step should not be able to hold the lifecycle path indefinitely after the notification has already been stored.

This change gives notification publishing a bounded window while keeping the existing behavior for successful publishes and fast publisher errors.

What changed

  • Add a default publish timeout to the notification manager.
  • Allow tests and future callers to override that timeout through manager dependencies.
  • Preserve duplicate notification handling as a no-op.
  • Cover both fast publisher errors and slow publisher timeout behavior in unit tests.

Verification

  • cd backend && go test ./internal/notify
  • npm run lint

@ChiragArora31 ChiragArora31 changed the title Bound notification publishing on the lifecycle path fix: bound notification publishing on the lifecycle path Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant