chore: restore gofmt/goimports formatting (unbreak Go CI)#2245
Open
rhiannalitchfield wants to merge 1 commit into
Open
chore: restore gofmt/goimports formatting (unbreak Go CI)#2245rhiannalitchfield wants to merge 1 commit into
rhiannalitchfield wants to merge 1 commit into
Conversation
The Go workflow (build-test "Check formatting" and the golangci-lint job) has been red on main since AgentWrapper#2219. That PR changed legacyProjectConfig.Repo to *yaml.Node and added a doc comment without re-running the formatter, leaving three files unformatted: - internal/legacyimport/config.go struct field alignment - internal/legacyimport/project_test.go local import grouping - internal/service/importer/importer_test.go struct expansion Apply `golangci-lint fmt` (gofmt + goimports with the repo's configured local-prefixes). Formatting only; no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rhiannalitchfield
force-pushed
the
fix/gofmt-formatting
branch
from
fcd945d to
06a276b
Compare
rhiannalitchfield
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores gofmt/goimports formatting on three files so the Go workflow passes again.
Why
mainhas been red on the Go workflow since #2219. That PR changedlegacyProjectConfig.Repofromstringto*yaml.Nodeand added a doc comment, which split the struct's gofmt alignment blocks, but it was merged without re-running the formatter. As a result, onmaintoday:build-testjob fails at Check formatting (gofmt -l .)lintjob fails at golangci-lint (goimports)Affected files:
internal/legacyimport/config.go— struct field alignmentinternal/legacyimport/project_test.go— local import grouping (goimportslocal-prefixes)internal/service/importer/importer_test.go— struct expansionHow
Ran
golangci-lint fmt(gofmt + goimports with the repo's configuredlocal-prefixes). Formatting only, no behavior change.Verification
gofmt -lclean on the touched filesgolangci-lint run→ 0 issuesgo build ./...,go vet ./..., andgo teston the touched packages all pass🤖 Generated with Claude Code