[codex] isolate worker MCP config#2232
Open
cneuralnetwork wants to merge 2 commits into
Open
Conversation
…ator into codex/issue-2195-worker-mcp-config # Conflicts: # frontend/forge.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds role-scoped MCP configuration for agent sessions so Claude Code workers no longer inherit the orchestrator/user MCP server set by default.
What changed
agentConfig.mcpsupport withinherit,none, andcustommodes.Root cause
AO already merged per-role agent/model/permission overrides, but MCP server selection was not represented in
AgentConfig, so Claude Code worker sessions fell back to the global Claude MCP configuration.Validation
SHELL=/bin/bash GOTOOLCHAIN=auto GOSUMDB=sum.golang.org go test ./...GOTOOLCHAIN=auto GOSUMDB=sum.golang.org go test -race ./internal/domain ./internal/session_manager ./internal/adapters/agent/claudecode ./internal/storage/sqlite/store ./internal/httpd/...GOTOOLCHAIN=auto GOSUMDB=sum.golang.org SHELL=/bin/bash go vet ./...npm run apinpm run frontend:typechecknpm --prefix frontend testgolangci-linton changed backend packages:0 issuesgit diff --checkFull
npm run lintstill reports unrelated pre-existinggoimportsfindings inbackend/internal/legacyimport/config.go,backend/internal/legacyimport/project_test.go, andbackend/internal/service/importer/importer_test.goafter itsgo test ./...step passes.Fixes #2195