fix: prioritize PR status over waiting input#2228
Open
cneuralnetwork wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prioritize PR-derived session statuses over a sticky
waiting_inputactivity state so workers that have opened PRs show the actionable PR pipeline state instead of remaining pinned toneeds_input.Root Cause
deriveStatusreturnedneeds_inputbefore evaluating PR facts. If a worker's last persisted activity signal waswaiting_input, newer PR facts such as an open PR or failing CI could not affect the display status.Changes
waiting_inputfor live sessions.waiting_inputcombined with open, failing, and absent PR facts.Testing
git diff --checkGOTOOLCHAIN=auto GOSUMDB=sum.golang.org go test ./internal/service/sessionGOTOOLCHAIN=auto GOSUMDB=sum.golang.org go test ./...; it hit unrelated local terminal/runtime failures inbackend/internal/adapters/runtime/tmux(no server running on /tmp/tmux-1000/default) andbackend/internal/terminal(fish-shell parsing during an attachment integration test). The changed session package passed.Fixes #2174