fix: deep-link PR attention actions#2200
Conversation
c0574af to
82709a7
Compare
82709a7 to
59eb4c2
Compare
harshitsinghbhandari
left a comment
There was a problem hiding this comment.
LGTM. Clean vertical slice: fetch submitted reviews from GitHub, persist them in the new pr_reviews table, thread them through to the dashboard so attention chips deep-link to the right place (the review, /conflicts, or the failing check). The issue-shaped-URL normalization (/issues/N -> /pull/N) is a nice root-cause fix, and switching the board card to role=button so nested links are clickable is the correct call.
The large diff is mostly the unavoidable cost of plumbing a new persisted entity through the signatures, not gold-plating. Verified the edge cases hold up: an APPROVED review correctly supersedes an earlier changes_requested, and bot-only attention no longer trips HasUnresolvedHumanComments.
Nit (non-blocking): prBaseUrl is a pure alias for prURL and prSubpageUrl is a single-value helper with one caller; both could inline. Not worth holding the PR.
|
Code LGTM - let us discuss on the UI part offline |

Summary
/pull/{number}before rendering PR links/conflictspageFixes #2198
Tests
npm run test -- pr-display.test.ts pr-hydration.test.tsxnpm run typecheck