Skip to content

fix: deep-link PR attention actions#2200

Merged
whoisasx merged 2 commits into
mainfrom
fix/dashboard-pr-attention-links-2198
Jun 29, 2026
Merged

fix: deep-link PR attention actions#2200
whoisasx merged 2 commits into
mainfrom
fix/dashboard-pr-attention-links-2198

Conversation

@whoisasx

Copy link
Copy Markdown
Collaborator

Summary

  • normalize GitHub issue-shaped PR URLs to /pull/{number} before rendering PR links
  • deep-link requested-change attention to review comments/files when no direct discussion URL is available
  • deep-link merge-conflict attention to GitHub's /conflicts page
  • make dashboard session cards allow nested attention links to be clicked directly

Fixes #2198

Tests

  • npm run test -- pr-display.test.ts pr-hydration.test.tsx
  • npm run typecheck

@whoisasx whoisasx force-pushed the fix/dashboard-pr-attention-links-2198 branch 2 times, most recently from c0574af to 82709a7 Compare June 26, 2026 18:53
@whoisasx whoisasx force-pushed the fix/dashboard-pr-attention-links-2198 branch from 82709a7 to 59eb4c2 Compare June 27, 2026 10:55
@whoisasx whoisasx requested a review from Copilot June 27, 2026 11:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@whoisasx

Copy link
Copy Markdown
Collaborator Author
Screenshot 2026-06-29 at 03 22 33

@harshitsinghbhandari harshitsinghbhandari left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean vertical slice: fetch submitted reviews from GitHub, persist them in the new pr_reviews table, thread them through to the dashboard so attention chips deep-link to the right place (the review, /conflicts, or the failing check). The issue-shaped-URL normalization (/issues/N -> /pull/N) is a nice root-cause fix, and switching the board card to role=button so nested links are clickable is the correct call.

The large diff is mostly the unavoidable cost of plumbing a new persisted entity through the signatures, not gold-plating. Verified the edge cases hold up: an APPROVED review correctly supersedes an earlier changes_requested, and bot-only attention no longer trips HasUnresolvedHumanComments.

Nit (non-blocking): prBaseUrl is a pure alias for prURL and prSubpageUrl is a single-value helper with one caller; both could inline. Not worth holding the PR.

@neversettle17-101

Copy link
Copy Markdown
Collaborator

Code LGTM - let us discuss on the UI part offline

@whoisasx whoisasx merged commit a31cf1b into main Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard PR attention links should deep-link to comments and conflicts

4 participants